This repository was archived by the owner on Nov 29, 2017. It is now read-only.
More flexible way of querying against ServiceNow#5
Open
dmfranko wants to merge 1 commit intoYaleSTC:masterfrom
Open
More flexible way of querying against ServiceNow#5dmfranko wants to merge 1 commit intoYaleSTC:masterfrom
dmfranko wants to merge 1 commit intoYaleSTC:masterfrom
Conversation
The “old” way basically forced you to use a specific operator. This will allow for the user to specify what operator should be used.
Contributor
|
I think this looks great, much cleaner too!
|
Closed
Contributor
|
Micah worked on something similar in #6 |
|
This way is definitely more powerful. Queries can also be joined with I am not sure how to make |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was messing around with something and using the service_now gem. I found that the where method didn't allow me to use a BETWEEN operator for dates. The “old” way basically forced you to use a specific operator. This will allow for the user to specify what operator should be used. This would break existing code if someone is using the where method, so if you want to accept this request and/or want me to make it backwards compatible.